Michael Ho has posted comments on this change. Change subject: IMPALA-3378/IMPALA-3379: fix various JNI issues ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2820/1/be/src/exec/hbase-table-scanner.cc File be/src/exec/hbase-table-scanner.cc: Line 544: ( parenthesis unnecessary Line 545: // cells_ = result.raw(); is this a comment or is it stale code ? http://gerrit.cloudera.org:8080/#/c/2820/1/be/src/exprs/hive-udf-call.h File be/src/exprs/hive-udf-call.h: Line 60: /// Must be called before creating any HiveUdfCall instances. Please also mention that it's called once at Impalad init time. http://gerrit.cloudera.org:8080/#/c/2820/1/be/src/util/jni-util.h File be/src/util/jni-util.h: Line 182: LocalToGlobalRef is this one actually used ? If it's for jobject subclasses, the one above should work, no ? -- To view, visit http://gerrit.cloudera.org:8080/2820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cd089e355d2ee2d5ace81f05b214272c05cf941 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
