Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3378/IMPALA-3379: fix various JNI issues ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2820/2/be/src/exec/external-data-source-executor.cc File be/src/exec/external-data-source-executor.cc: Line 61: jclass cl = env->FindClass( : "com/cloudera/impala/extdatasource/ExternalDataSourceExecutor"); : RETURN_ERROR_IF_EXC(env); : RETURN_IF_ERROR(JniUtil::LocalToGlobalRef(env, cl, &executor_class_)); I think we can use JniUtil::GetGlobalClassRef() here to make it look cleaner, although the current one works too. -- To view, visit http://gerrit.cloudera.org:8080/2820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cd089e355d2ee2d5ace81f05b214272c05cf941 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
