Dan Hecht has posted comments on this change. Change subject: IMPALA-2076: Correct execution time tracking for DataStreamSender. ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/2578/6//COMMIT_MSG Commit Message: Line 10: time network time http://gerrit.cloudera.org:8080/#/c/2578/6/be/src/runtime/backend-client.h File be/src/runtime/backend-client.h: Line 40: if (transmit_csw_ != NULL) { > A couple of cases: FlushAndSendEos does send the final buffered row batch, so it is sending data. I think we should include it. And then just fix the unit test. Line 46: recv_TransmitData > I explained this earlier, also mentioned in commit message. The commit message wasn't clear to me, this is much clearer, thanks. How about adding a brief comment to thrift_transmit_timer_ to explain it is the wall time spent sending data over the network. -- To view, visit http://gerrit.cloudera.org:8080/2578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c530b2056d852c8bcac6263e9e6b1a6bede1047 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
