Juan Yu has posted comments on this change. Change subject: IMPALA-2076: Correct execution time tracking for DataStreamSender. ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/2578/6/be/src/runtime/backend-client.h File be/src/runtime/backend-client.h: Line 40: if (transmit_csw_ != NULL) { > FlushAndSendEos does send the final buffered row batch, so it is sending da Do you mean the SendCurrentBatch() there? All row batch sending will eventually call DataStreamSender::Channel::TransmitDataHelper() so the time is already tracked. We just don't count the final doRpc() call. see be/src/runtime/data-stream-sender.cc L285-290 it doesn't call params.__set_row_batch(). it just sends eos flag. -- To view, visit http://gerrit.cloudera.org:8080/2578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c530b2056d852c8bcac6263e9e6b1a6bede1047 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
