Dan Hecht has posted comments on this change. Change subject: IMPALA-3115: Hoist some variables out of loops in cross-compiled code. ......................................................................
Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/2661/8/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 145: /// An iterator for going through a row batch, starting at 'row_idx'. how about also noting in the comment that using the iterator is more efficient than GetRow() because it avoids loading row-batch state and doing a multiply on each loop iteration. so that future readers know why we have it and when to use it. Line 178: in the iterator delete (it's not a row in the iterator, it's a row in the row-batch). -- To view, visit http://gerrit.cloudera.org:8080/2661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7152b1fb094b3c3574d203e3774f4297f2225dc Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
