Tim Armstrong has posted comments on this change. Change subject: IMPALA-3115: Hoist some variables out of loops in cross-compiled code. ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/2661/6/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 398: > I like this but please get a second opinion since we don't have a pattern l Why not have the syntax closer to BOOST_FOREACH? I.e. FOREACH_ROW(batch, 0, row) { } You could also consider using the c++11 for loop syntax, but that might be more trouble that it's worth. FWIW the google C++ style guide says "Try not to use macros that expand to unbalanced C++ constructs, or at least document that behavior well." https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros -- To view, visit http://gerrit.cloudera.org:8080/2661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7152b1fb094b3c3574d203e3774f4297f2225dc Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
