Hello Casey Ching,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2837
to review the following change.
Change subject: deploy: move cluster argument back into main parser
......................................................................
deploy: move cluster argument back into main parser
It was confusing for --cluster to be a parent parser argument. It meant that
the following command line doesn't work:
deploy.py --host foo --cluster c1 clone IMPALA-KUDU IMPALA-1
Instead, users had to do the following:
deploy.py --host foo clone --cluster c1 IMPALA-KUDU IMPALA-1
Which is unintuitive; most people expect optional parameters to be grouped
together. So let's move the --cluster argument out of the parent parser and
into the main parser. That means it must be provided in the same group as
--host, --user, and --password.
Change-Id: I92dc5d22328eb12951d086a5070aec11a0e5c443
---
M infra/deploy/deploy.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/37/2837/1
--
To view, visit http://gerrit.cloudera.org:8080/2837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92dc5d22328eb12951d086a5070aec11a0e5c443
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
