Adar Dembo has posted comments on this change. Change subject: deploy: move cluster argument back into main parser ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2837/1/infra/deploy/deploy.py File infra/deploy/deploy.py: Line 70: parents_parser.add_argument("service_name", type=str, > Won't this have the same problem? Maybe move this up too and remove the par But service_name is a positional argument which we want after the command. That is, we want: deploy.py clone <service name> <based on> And not: deploy.py <service name> clone <based on> If we moved it out of parents_parser, users would be forced to add it before 'clone' or 'create'. -- To view, visit http://gerrit.cloudera.org:8080/2837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92dc5d22328eb12951d086a5070aec11a0e5c443 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-HasComments: Yes
