Dan Hecht has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log ......................................................................
Patch Set 5: > thanks, I used LOG(INFO) to output that, they are empty and front() > does not crash.. I will try asan build and release build later... > > Is the dcheck different than LOG(INFO) DCHECK() verifies invariants. In debug builds, it will generate a core when the invariant is violated. Whether you can see the crash or not will depend on how memory is recycled, etc, so it may be hard to repro. But since we know doing front() on an empty vector is illegal, the DCHECK will point out that bug and be a pretty good "repro" of the problem. -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: No
