Dan Hecht has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/6/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 121: void GetErrors(ErrorLogMap* errors); > i still think return a copy is better. i can change the method name. When we return objects, we usually return by reference, not by copy, which is why returning by copy would be surprising. Using the out param makes it obvious at the callsite what is happening. -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
