Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3412: fix CHAR codegen crash in tuple comparator ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/2876/3/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: Line 70: bool has_char_arg = type_.type == TYPE_CHAR; Arg sorry, didn't read this correctly, your old name did make sense (the comment helps :)). Since this actually not accurate, can you revert it or change it to something like uses_char? -- To view, visit http://gerrit.cloudera.org:8080/2876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I189073d46a10988803d572928a38f4a718690fa3 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
