Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3412: fix CHAR codegen crash in tuple comparator ......................................................................
IMPALA-3412: fix CHAR codegen crash in tuple comparator Attempting to codegen a sort where the sort expr has a CHAR type as an intermediate result fails completely. The problem is that ScalarFnCall checked whether its input arguments were CHAR to disable codegen, but didn't check its output. This patch also replaces some incorrect codegen CHAR logic that should not be executed with DCHECKs. Testing: The test is a minimal reproduction of the issue. The test is executed both by the sorter and top-n nodes so covers both cases. Change-Id: I189073d46a10988803d572928a38f4a718690fa3 Reviewed-on: http://gerrit.cloudera.org:8080/2876 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins --- M be/src/codegen/codegen-anyval.cc M be/src/exprs/scalar-fn-call.cc M be/src/util/tuple-row-compare.cc M testdata/workloads/functional-query/queries/QueryTest/top-n.test 4 files changed, 38 insertions(+), 11 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I189073d46a10988803d572928a38f4a718690fa3 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
