Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2864/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 127: def build_kudu_stub(toolchain_root, kudu_version, compiler): > Can we move this logic to a different file? Or at least to the bottom of th Moved to the bottom. Line 186: if sym_type.upper() not in "TW": > Was stubbing weak symbols necessary to get impala to think? This is all ver I never tried that. I used to think Todd knew what he was doing :) It turns out only the strong symbols are needed. At least things compile and the be tests pass. -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
