Matthew Jacobs has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation ......................................................................
Patch Set 2: > (1 comment) > > Were you able to test this, at least manually for now? I think > that's OK for getting this in. We also need to talk to Alex about > changes to the jenkins jobs as we were talking about. FWIW there are some weak symbols from Kudu that look like they're related to templates. It's probably fine not to have them, but we should run a private job to test. mj@mj-desktop:~/dev/Impala$ nm --defined-only -D ./toolchain/kudu-0.8.0-RC1/release/lib/libkudu_client.so | grep " W " | c++filt | grep "kudu::" 000000000009d8e0 W kudu::Status kudu::KuduPartialRow::SetSliceCopy<kudu::TypeTraits<(kudu::DataType)12> >(int, kudu::Slice const&) 000000000009f060 W kudu::Status kudu::KuduPartialRow::SetSliceCopy<kudu::TypeTraits<(kudu::DataType)12> >(kudu::Slice const&, kudu::Slice const&) 000000000009d630 W kudu::Status kudu::KuduPartialRow::SetSliceCopy<kudu::TypeTraits<(kudu::DataType)8> >(int, kudu::Slice const&) 000000000009e910 W kudu::Status kudu::KuduPartialRow::SetSliceCopy<kudu::TypeTraits<(kudu::DataType)8> >(kudu::Slice const&, kudu::Slice const&) 000000000009f520 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)10> >(int, kudu::TypeTraits<(kudu::DataType)10>::cpp_type const&, bool) 00000000000a11e0 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)10> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)10>::cpp_type const&, bool) 000000000009f750 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)11> >(int, kudu::TypeTraits<(kudu::DataType)11>::cpp_type const&, bool) 00000000000a1650 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)11> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)11>::cpp_type const&, bool) 000000000009edd0 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)12> >(int, kudu::TypeTraits<(kudu::DataType)12>::cpp_type const&, bool) 00000000000a23a0 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)12> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)12>::cpp_type const&, bool) 000000000009e450 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)13> >(int, kudu::TypeTraits<(kudu::DataType)13>::cpp_type const&, bool) 00000000000a0d70 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)13> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)13>::cpp_type const&, bool) 000000000009db90 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)1> >(int, kudu::TypeTraits<(kudu::DataType)1>::cpp_type const&, bool) 000000000009fbb0 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)1> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)1>::cpp_type const&, bool) 000000000009ddc0 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)3> >(int, kudu::TypeTraits<(kudu::DataType)3>::cpp_type const&, bool) 00000000000a0020 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)3> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)3>::cpp_type const&, bool) 000000000009dff0 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)5> >(int, kudu::TypeTraits<(kudu::DataType)5>::cpp_type const&, bool) 00000000000a0490 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)5> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)5>::cpp_type const&, bool) 000000000009e220 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)7> >(int, kudu::TypeTraits<(kudu::DataType)7>::cpp_type const&, bool) 00000000000a0900 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)7> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)7>::cpp_type const&, bool) 000000000009e680 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)8> >(int, kudu::TypeTraits<(kudu::DataType)8>::cpp_type const&, bool) 00000000000a1f30 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)8> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)8>::cpp_type const&, bool) 000000000009f980 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)9> >(int, kudu::TypeTraits<(kudu::DataType)9>::cpp_type const&, bool) 00000000000a1ac0 W kudu::Status kudu::KuduPartialRow::Set<kudu::TypeTraits<(kudu::DataType)9> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)9>::cpp_type const&, bool) 00000000000a3830 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)10> >(int, kudu::TypeTraits<(kudu::DataType)10>::cpp_type*) const 00000000000a3ae0 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)11> >(int, kudu::TypeTraits<(kudu::DataType)11>::cpp_type*) const 00000000000a4050 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)12> >(int, kudu::TypeTraits<(kudu::DataType)12>::cpp_type*) const 00000000000a3580 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)13> >(int, kudu::TypeTraits<(kudu::DataType)13>::cpp_type*) const 00000000000a2ac0 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)1> >(int, kudu::TypeTraits<(kudu::DataType)1>::cpp_type*) const 00000000000a2d70 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)3> >(int, kudu::TypeTraits<(kudu::DataType)3>::cpp_type*) const 00000000000a3020 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)5> >(int, kudu::TypeTraits<(kudu::DataType)5>::cpp_type*) const 00000000000a32d0 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)7> >(int, kudu::TypeTraits<(kudu::DataType)7>::cpp_type*) const 00000000000a3d90 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)8> >(int, kudu::TypeTraits<(kudu::DataType)8>::cpp_type*) const 00000000000a2810 W kudu::Status kudu::KuduPartialRow::Get<kudu::TypeTraits<(kudu::DataType)9> >(int, kudu::TypeTraits<(kudu::DataType)9>::cpp_type*) const 0000000000075c60 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)10> >(int, kudu::TypeTraits<(kudu::DataType)10>::cpp_type*) const 0000000000075ec0 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)10> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)10>::cpp_type*) const 0000000000076320 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)11> >(int, kudu::TypeTraits<(kudu::DataType)11>::cpp_type*) const 0000000000076580 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)11> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)11>::cpp_type*) const 00000000000770b0 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)12> >(int, kudu::TypeTraits<(kudu::DataType)12>::cpp_type*) const 0000000000077320 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)12> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)12>::cpp_type*) const 00000000000755a0 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)13> >(int, kudu::TypeTraits<(kudu::DataType)13>::cpp_type*) const 0000000000075800 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)13> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)13>::cpp_type*) const 0000000000073aa0 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)1> >(int, kudu::TypeTraits<(kudu::DataType)1>::cpp_type*) const 0000000000073d00 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)1> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)1>::cpp_type*) const 0000000000074160 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)3> >(int, kudu::TypeTraits<(kudu::DataType)3>::cpp_type*) const 00000000000743c0 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)3> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)3>::cpp_type*) const 0000000000074820 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)5> >(int, kudu::TypeTraits<(kudu::DataType)5>::cpp_type*) const 0000000000074a80 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)5> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)5>::cpp_type*) const 0000000000074ee0 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)7> >(int, kudu::TypeTraits<(kudu::DataType)7>::cpp_type*) const 0000000000075140 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)7> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)7>::cpp_type*) const 00000000000769e0 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)8> >(int, kudu::TypeTraits<(kudu::DataType)8>::cpp_type*) const 0000000000076c50 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)8> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)8>::cpp_type*) const 00000000000733e0 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)9> >(int, kudu::TypeTraits<(kudu::DataType)9>::cpp_type*) const 0000000000073640 W kudu::Status kudu::client::KuduScanBatch::RowPtr::Get<kudu::TypeTraits<(kudu::DataType)9> >(kudu::Slice const&, kudu::TypeTraits<(kudu::DataType)9>::cpp_type*) const 0000000000178b00 W void std::vector<kudu::Slice, std::allocator<kudu::Slice> >::_M_emplace_back_aux<kudu::Slice const&>(kudu::Slice const&) 00000000001c8950 W void std::vector<kudu::Slice, std::allocator<kudu::Slice> >::_M_emplace_back_aux<kudu::Slice>(kudu::Slice&&) 0000000000178b00 W void std::vector<kudu::Slice, std::allocator<kudu::Slice> >::_M_emplace_back_aux<kudu::Slice const&>(kudu::Slice const&) 00000000001c8950 W void std::vector<kudu::Slice, std::allocator<kudu::Slice> >::_M_emplace_back_aux<kudu::Slice>(kudu::Slice&&) 0000000000083580 W void std::vector<kudu::client::KuduColumnSpec*, std::allocator<kudu::client::KuduColumnSpec*> >::_M_emplace_back_aux<kudu::client::KuduColumnSpec* const&>(kudu::client::KuduColumnSpec* const&) 0000000000083580 W void std::vector<kudu::client::KuduColumnSpec*, std::allocator<kudu::client::KuduColumnSpec*> >::_M_emplace_back_aux<kudu::client::KuduColumnSpec* const&>(kudu::client::KuduColumnSpec* const&) 0000000000052400 W void std::vector<kudu::client::KuduTabletServer*, std::allocator<kudu::client::KuduTabletServer*> >::_M_emplace_back_aux<kudu::client::KuduTabletServer* const&>(kudu::client::KuduTabletServer* const&) 0000000000052400 W void std::vector<kudu::client::KuduTabletServer*, std::allocator<kudu::client::KuduTabletServer*> >::_M_emplace_back_aux<kudu::client::KuduTabletServer* const&>(kudu::client::KuduTabletServer* const&) 0000000000064a40 W void std::vector<kudu::client::KuduError*, std::allocator<kudu::client::KuduError*> >::_M_emplace_back_aux<kudu::client::KuduError*>(kudu::client::KuduError*&&) 0000000000064a40 W void std::vector<kudu::client::KuduError*, std::allocator<kudu::client::KuduError*> >::_M_emplace_back_aux<kudu::client::KuduError*>(kudu::client::KuduError*&&) -- To view, visit http://gerrit.cloudera.org:8080/2864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54292095692ce38c255a8df48cf8f3f655d797b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
