Michael Brown has posted comments on this change. Change subject: Add Kudu test helpers ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2855/4/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: Line 190: env["LD_LIBRARY_PATH"] = "{0}{1}lib{2}{0}{1}lib64".format( : kudu_client_dir, os.path.sep, os.path.pathsep) Just a comment because this made me think: if whatever OS + toolchain version you're using puts this in a different path (lib64 vs. lib), I wonder whether our toolchain should provide a per-toolchain sourceable file that provides paths so that we don't have to do workarounds like this. Way out of scope for this effort; just a thought. -- To view, visit http://gerrit.cloudera.org:8080/2855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e5e22b38d5bd09a36238e66a69aa42d1a941de7 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
