Casey Ching has posted comments on this change. Change subject: Add Kudu test helpers ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2855/1/tests/conftest.py File tests/conftest.py: Line 242: > Do you mind updating both the unique_database's and this fixture's docstrin Done Line 260: def conn(request): > impala_connection ? Since conn/cursor would be common, maybe these can be exceptions? It's going to be verbose to see "impala_cursor" and "impala_conn" all over the place. It'll take a little ramp up for a new reader to understand but it shouldn't be too difficult. Any connection/cursor that isn't an impala connection/cursor would be explicitly named. -- To view, visit http://gerrit.cloudera.org:8080/2855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e5e22b38d5bd09a36238e66a69aa42d1a941de7 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
