Dimitris Tsirogiannis has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE ......................................................................
Patch Set 10: (4 comments) Are you going to simplify the DdlDelegate in a follow up patch? http://gerrit.cloudera.org:8080/#/c/2617/10//COMMIT_MSG Commit Message: Line 23: Add KUDU as a file format. What do we gain by doing that other than being able to say "STORED AS KUDU"? Couldn't we just augment the syntax of CREATE TABLE to be something like CREATE KUDU TABLE and simply pass a variable indicating which storage engine we use (impala or kudu)? http://gerrit.cloudera.org:8080/#/c/2617/10/fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java File fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java: Line 350: TODO: Investigate what happens if more than one DistributeComponent : // without any columns is specified. Maybe reject that here? Are you going to address these TODOs in a follow up patch? http://gerrit.cloudera.org:8080/#/c/2617/10/fe/src/main/java/com/cloudera/impala/catalog/delegates/KuduDdlDelegate.java File fe/src/main/java/com/cloudera/impala/catalog/delegates/KuduDdlDelegate.java: Line 88: of typo: if Line 177: schema. maybe "schema stored in msTable_."? -- To view, visit http://gerrit.cloudera.org:8080/2617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic141102818b6dad3016181b179a14024d0ff709d Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
