Marcel Kornacker has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE ......................................................................
Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/2617/10/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeDDLTest.java: Line 1317: {"TEXTFILE", "SEQUENCEFILE", "PARQUET", "PARQUETFILE", "RCFILE"}; no kudu? Line 1537: "'kudu.key_columns' = 'a,b,c'" + general questions: - what are the data types of the key columns? - should the key columns be listed in the columns list, and then referenced in the key_columns property (just like the standard sql 'primary key' syntax for composite pks)? i understand that this deviates from hive's 'partitioned by' syntax. Line 1654: "ROW FORMAT cannot be specified for file format KUDU."); kudu shouldn't be referred to as a file format (storage manager?) Line 1678: "A storage handler cannot be specified for a Kudu table."); this doesn't need to return a different error message than l1662. -- To view, visit http://gerrit.cloudera.org:8080/2617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic141102818b6dad3016181b179a14024d0ff709d Gerrit-PatchSet: 10 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
