Casey Ching has posted comments on this change.

Change subject: Kudu: Update DCHECK about plan nodes that don't use runtime 
filters
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2900/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 520:         DCHECK(plan_node.__isset.hbase_scan_node || 
plan_node.__isset.kudu_scan_node)
> I think this should also fail for external data source scan nodes, i.e. 'da
Is there some way to verify that? I guess I can just add it if you are sure.


-- 
To view, visit http://gerrit.cloudera.org:8080/2900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice6f7efaa701b60d0e5b75b8696d7a6e6ce96de6
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-HasComments: Yes

Reply via email to