Matthew Jacobs has posted comments on this change. Change subject: Kudu: Update DCHECK about plan nodes that don't use runtime filters ......................................................................
Patch Set 1: (1 comment) I'm fine with not waiting on the ext data source issue, but let's get Dimitris to OK this as well. http://gerrit.cloudera.org:8080/#/c/2900/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 519: scan nodes should use runtime filters I'm confused by this... The frontend shouldn't be targeting filters at nodes that aren't capable of handling them, i.e. we shouldn't even be getting here once we fix the Frontend (which is a simple fix). When Dimitris makes that change, he should remove that TODO. Actually supporting runtime filters for HBase and Kudu scan nodes seems like a larger feature, not really tracked via a TODO. What about saying // TODO: Frontend should not target filters at unsupported scan nodes. -- To view, visit http://gerrit.cloudera.org:8080/2900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice6f7efaa701b60d0e5b75b8696d7a6e6ce96de6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
