Wes McKinney has posted comments on this change. Change subject: Initial structure for the C++ hiveserver2 client. ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/2645/9/src/hs2client/columnar-row-set.h File src/hs2client/columnar-row-set.h: Line 47: // cout << col->data()[i] << "\n"; Dereference needed here. However: API question, should col->data() return const std::vector<T>&? http://gerrit.cloudera.org:8080/#/c/2645/9/src/hs2client/fetch-results.h File src/hs2client/fetch-results.h: Line 28: // oriented or column oriented protocol is being used, respectively. How should code know what kind of FetchResults they have (should there be a fetch_results->is_columnar() helper function)? Or should one look at the session / connection? http://gerrit.cloudera.org:8080/#/c/2645/9/src/hs2client/public-api-test.cc File src/hs2client/public-api-test.cc: Line 28: FAIL() << "Thrift headers should not be in the public API"; > nice. (I guess we have to find a way to remember to add new headers in the I would suggest adding a hs2client/api.h for public API users (so that refactoring is less invasive) -- To view, visit http://gerrit.cloudera.org:8080/2645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be82d5897ad6093116915b17924674c4ae508a0 Gerrit-PatchSet: 9 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
