Thomas Tauber-Marshall has posted comments on this change. Change subject: Initial structure for the C++ hiveserver2 client. ......................................................................
Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/2645/10/src/hs2client/hs2service-test.cc File src/hs2client/hs2service-test.cc: Line 25: > How are you tracking test coverage to add later? We should add timeouts to I just filed an issue: https://github.com/cloudera/hs2client/issues/7 http://gerrit.cloudera.org:8080/#/c/2645/10/src/hs2client/hs2service.h File src/hs2client/hs2service.h: Line 83: use_ssl > comment that this is unsupported Done Line 83: conn_timeout > Add a comment for this. What units is this in? What is 0? Are negative vals Done Line 95: // Set the receive timeout. > units? Done http://gerrit.cloudera.org:8080/#/c/2645/10/src/hs2client/operation.h File src/hs2client/operation.h: Line 73: , if : // given > remove, let's have it always set. Done Line 74: If all of the results have been fetched already, Fetch will return success : // but 'results' will be empty > Remove this too, the caller should check has_more_rows to determine eos. Done Line 76: = NULL > remove default parameter so that it's always set Done Line 78: = NULL > same Done -- To view, visit http://gerrit.cloudera.org:8080/2645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be82d5897ad6093116915b17924674c4ae508a0 Gerrit-PatchSet: 10 Gerrit-Project: hs2client Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
