Dan Hecht has posted comments on this change. Change subject: IMPALA-3286: Software prefetching for hash table build. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2896/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: Line 186: for (int i = 0; i < build_expr_ctxs_.size(); ++i) { > I believe it's already being codegen'ed by CodegenEquals(). Oh yeah, I forgot about that even though I had just looked at it earlier in the patch :) -- To view, visit http://gerrit.cloudera.org:8080/2896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib85e7fc162ad25c849b9e716b629e226697cd940 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
