Michael Ho has posted comments on this change. Change subject: IMPALA-3286: Software prefetching for hash table build. ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2896/4/be/src/exec/hash-table.inline.h File be/src/exec/hash-table.inline.h: Line 58: GetRow(bucket, ht_ctx->row_))) { > We still have to differentiate between the build and probe exprs here (as w Unfortunately, Equals() in the interpretation path only works with build exprs now. Need to fix it so it will work with Probe() too. The codegen'ed version actually works. -- To view, visit http://gerrit.cloudera.org:8080/2896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib85e7fc162ad25c849b9e716b629e226697cd940 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
