Tim Armstrong has posted comments on this change. Change subject: IMPALA-3375: Improve TopN performance with a trivial Compare object. ......................................................................
Patch Set 1: (1 comment) I haven't done a full review (although I'm happy to if you need another reviewer) but I wanted to point out this weirdness we introduced as a workaround in a previous patch. http://gerrit.cloudera.org:8080/#/c/2918/1/be/src/util/tuple-row-compare.h File be/src/util/tuple-row-compare.h: Line 143: codegend_compare_fn_ We introduced a pointer indirection here in a different patch, so the wrapper class adds a second layer of indirection to get to the actual function pointer. Maybe copy this pointer into the wrapper class to get around that? -- To view, visit http://gerrit.cloudera.org:8080/2918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24755227b5bbbca6ad7c7d31d9bb8e132ca89e11 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
