Jim Apple has posted comments on this change. Change subject: IMPALA-3375: Improve TopN performance with a trivial Compare object. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2918/1/be/src/util/tuple-row-compare.h File be/src/util/tuple-row-compare.h: Line 143: codegend_compare_fn_ > Do you know if the comparator is copied anywhere else aside from the priori I didn't find any other comparator copies in our code - for this or any of the other comparators written by us. I tried removing that indirection and the targeted perf benchmark did not improve. -- To view, visit http://gerrit.cloudera.org:8080/2918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24755227b5bbbca6ad7c7d31d9bb8e132ca89e11 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
