Michael Ho has posted comments on this change. Change subject: Strip global constructors and destructors from codegen module ......................................................................
Patch Set 3: Code-Review+1 Interesting. I thought they were needed for exception. When I looked at the IR file last time, I saw some boost exception related functions in the global_ctors array so I thought we couldn't get rid of them until we can compile with -fnoexception. Apparently, that's not the case anymore. -- To view, visit http://gerrit.cloudera.org:8080/2910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f4f5e08e506ad3a9c27c684daeb3344bdaec8b6 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: No
