Tim Armstrong has posted comments on this change. Change subject: Strip global constructors and destructors from codegen module ......................................................................
Patch Set 4: It should work fine. The only case that would be a problem is if it was in a program where the I/O streams library wasn't included in any of the linked modules and the magic ios_base::Init() object wasn't pulled in from any header file. http://en.cppreference.com/w/cpp/io/ios_base/Init I can't think of a scenario where we'd use I/O streams in codegen'd code but not in non-codegen'd code. -- To view, visit http://gerrit.cloudera.org:8080/2910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f4f5e08e506ad3a9c27c684daeb3344bdaec8b6 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
