Casey Ching has posted comments on this change. Change subject: IMPALA-2418 Display truncated Details column in profile summary ......................................................................
Patch Set 1: (4 comments) Thanks for doing this! http://gerrit.cloudera.org:8080/#/c/2930/1/be/src/util/table-printer.cc File be/src/util/table-printer.cc: Line 66: if (i == 1) { Impala's code style is to use single line "if" statements when possible. This one can be shortened. Line 77: if(row[row.size() - 1].size() > widths[row.size() - 1] - colpad) { I think there's enough duplication in this block to justify naming some of the common patterns. Hopefully it'll read a little better after that. Ex last_col_idx = row.size() - 1; last_col_val = row[last_col_idx]; last_col_witdh = ... Line 80: for (int loc = (widths[row.size() - 1] - colpad - 3); loc < row[row.size() - 1].size(); loc += (widths[row.size() - 1] - colpad - 3)) { 90 char line limit Line 102: if (i != 0) { Same here about single line. -- To view, visit http://gerrit.cloudera.org:8080/2930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I228057dc134cb46673d8370ff859c00cd9739cd4 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Peter Ebert Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-HasComments: Yes
