Casey Ching has posted comments on this change. Change subject: IMPALA-2418 Display truncated Details column in profile summary ......................................................................
Patch Set 3: Code-Review+1 (1 comment) It would be great if there was some test for this. http://gerrit.cloudera.org:8080/#/c/2930/3/be/src/util/table-printer.cc File be/src/util/table-printer.cc: Line 77: int last_col_size = row[row.size() - 1].size(); I'd probably still create a var for "row.size() - 1" but I'm guessing you considered that already. -- To view, visit http://gerrit.cloudera.org:8080/2930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I228057dc134cb46673d8370ff859c00cd9739cd4 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Peter Ebert Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-HasComments: Yes
