Tim Armstrong has posted comments on this change. Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants. ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2826/5/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 1329: if > This num_free_buffers() as well as the available_allocated_buffers() (l1348 I thought I'd respond to this comment to save you any time from thinking about it more. This logic is totally broken as your surmised - it's IMPALA-1590. It made sense in the initial version of the block mgr when it was owned by the sorter and not shared between operators. The sorter wasn't properly adjusted when that changed. The follow-up patch tackles that issue separately since it's more of an algorithm change than just refactoring. -- To view, visit http://gerrit.cloudera.org:8080/2826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c619e81fd1b8ac50e257172c8bce101a112b52a Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
