Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3344: Simplify sorter and document/enforce invariants. ......................................................................
Patch Set 5: Yeah, after I read more of the code I remembered that issue which we've repeatedly hacked around crashes for pretty much every release. Sorry some of the comments from my first few hours of reviewing are a bit more ignorant than my later ones, after I got back up to speed on some of this which I had looked at in part in the past. I don't think I've ever done a full reading of this code though, so this was good for me. Most of my comments are directed at the refactoring effort though. -- To view, visit http://gerrit.cloudera.org:8080/2826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c619e81fd1b8ac50e257172c8bce101a112b52a Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
