Marcel Kornacker has posted comments on this change. Change subject: MT: Planner for multi-threaded execution ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2846/1/be/src/service/query-options.cc File be/src/service/query-options.cc: Line 391: case TImpalaQueryOptions::MT_NUM_CORES: { > ? i think we need to pick a name that doesn't sound too esoteric. i don't think "fragment threads" is a particularly easy concept to comprehend. also, there will be lots of threads floating around in the system (at most #fragments * mt_num_cores), and users might complain that this vastly exceeds the value of this option (and think that something isn't working right). i'd like to avoid that. mt_num_query_cores? this is supposed to let the user choose how many cores will be actively used by a query. -- To view, visit http://gerrit.cloudera.org:8080/2846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3c34dd3f9190a131e6f03d901b4bfcd164a5174 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
