Marcel Kornacker has posted comments on this change. Change subject: MT: Planner for multi-threaded execution ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2846/3/fe/src/main/java/com/cloudera/impala/planner/ParallelPlanner.java File fe/src/main/java/com/cloudera/impala/planner/ParallelPlanner.java: Line 181: PlanId parentPlanId = join.getFragment().getPlanId(); > Why would it start out as null? If we call this function then we certainly but you need to pass that down to the children in l97. i'll change it, it's a wash in terms of lines of code, but it doesn't need a global data structure. http://gerrit.cloudera.org:8080/#/c/2846/3/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test: Line 129: | hash table id: 00 > Works for me, but let's use a consistency format, i.e. hash-table-id=00 Done -- To view, visit http://gerrit.cloudera.org:8080/2846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3c34dd3f9190a131e6f03d901b4bfcd164a5174 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
