Alex Behm has posted comments on this change. Change subject: Optimized ReadValueBatch() for Parquet scalar column readers. ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/2843/4/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1553: return pool->mem_tracker()->MemLimitExceeded( > Does this fit on one line now? 94 chars :( Line 1578: if (UNLIKELY(num_cached_levels_ == INVALID_LEVEL)) { > Is this the right constant? num_cached_levels_ isn't a level. Reworked to make FillCache() return a bool Line 1613: if (num_values < batch_size && NextCounts<int16_t>()) { > We're getting down to nits, but consider inverting the condition to reduce Works for me; Done. Line 1618: } while (true); > Might as well make it while (true) {}, seems more idiomatic. Done -- To view, visit http://gerrit.cloudera.org:8080/2843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21fa9b050a45f2dd45cc0091ea5b008d3c0a3f30 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
