Marcel Kornacker has posted comments on this change. Change subject: Optimized ReadValueBatch() for Parquet scalar column readers. ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2843/5/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 827: bool MaterializeValueBatch(MemPool* pool, int max_values, int tuple_size, instead of calling this for !materialized && !in_collection, it makes more sense to specialize that logic (and maybe handle it in the caller). you in essence just drain/discard the values in the level cache and set *num_values, which doesn't require a loop. Line 1566: valid = Get(&level); outside scope of this change, but the LevelDecoder shouldn't be a subclass of RleDecoder (it should contain one) -- To view, visit http://gerrit.cloudera.org:8080/2843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21fa9b050a45f2dd45cc0091ea5b008d3c0a3f30 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
