Marcel Kornacker has posted comments on this change. Change subject: MT: Planner for multi-threaded execution ......................................................................
Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/2846/5/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 188: 44: optional i32 mt_num_cores = 1 > It seems like a bad idea to ship this option. Users will see it (it will tu fair concern. let's solve that by having a blacklist of invisible options in the shell, or something like that. http://gerrit.cloudera.org:8080/#/c/2846/5/fe/src/main/java/com/cloudera/impala/common/TreeNode.java File fe/src/main/java/com/cloudera/impala/common/TreeNode.java: Line 30: protected TreeNode() {} > is this still necessary? Done http://gerrit.cloudera.org:8080/#/c/2846/5/fe/src/main/java/com/cloudera/impala/planner/ParallelPlanner.java File fe/src/main/java/com/cloudera/impala/planner/ParallelPlanner.java: Line 32: * (= sequence of plan fragments) into a (logical) tree of distributed plans. The root > also 'tree' here, no? Done Line 35: * single plan P are grouped together into a cohort. In other words, the assignment > remove (you don't refer to P anywhere else) Done Line 36: * to cohorts represents the tree structure of the plans (this is distinct from > IIUC, there's one bit of information that would make this more clear: one p Done -- To view, visit http://gerrit.cloudera.org:8080/2846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3c34dd3f9190a131e6f03d901b4bfcd164a5174 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
