Dimitris Tsirogiannis has posted comments on this change. Change subject: Remove DDL delegates ......................................................................
Patch Set 1: (6 comments) Nice! Mostly nits... http://gerrit.cloudera.org:8080/#/c/2996/1//COMMIT_MSG Commit Message: Line 9: ass typo http://gerrit.cloudera.org:8080/#/c/2996/1/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1144: delegate Maybe we should update the comments to not reference the concept of delegate any more. http://gerrit.cloudera.org:8080/#/c/2996/1/fe/src/main/java/com/cloudera/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/KuduCatalogOpExecutor.java: Line 44: XXX: Very insightful comment :) Line 56: msTable nit: the input param is 'msTbl' Line 124: * TableNotFoundException is thrown. nit: You may also want to mention that an exception is thrown if we fail to drop the table in kudu. Line 213: KuduClient Out of curiosity, does the creation of a kudu client always succeed, even if the kudu masters are not accessible? -- To view, visit http://gerrit.cloudera.org:8080/2996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37f964f8b663fff219aa4eff3e2ef8e89217acf3 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
