Dimitris Tsirogiannis has posted comments on this change. Change subject: Remove DDL delegates ......................................................................
Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/2996/2/fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java File fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java: Line 31: import com.cloudera.impala.service.KuduCatalogOpExecutor; nit: we keep the imports sorted, right? http://gerrit.cloudera.org:8080/#/c/2996/2/fe/src/main/java/com/cloudera/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/KuduCatalogOpExecutor.java: Line 44: provide functionality that isn't yet in : * Hive Maybe mention what functionality is that? -- To view, visit http://gerrit.cloudera.org:8080/2996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37f964f8b663fff219aa4eff3e2ef8e89217acf3 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
