Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3232: Allow not-exists uncorrelated subqueries ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2792/1//COMMIT_MSG Commit Message: Line 7: IMPALA-3232: Allow not-exists uncorrelated subqueries > Can you add a short description of how this fix works (e.g. what kind of re Done http://gerrit.cloudera.org:8080/#/c/2792/1/fe/src/main/java/com/cloudera/impala/analysis/StmtRewriter.java File fe/src/main/java/com/cloudera/impala/analysis/StmtRewriter.java: Line 434: // TODO: Remove this when we support independent subquery evaluation. > Remove this Done Line 438: We don't have an ON clause predicate to create an equi-join. Rewrite the : // subquery using a CROSS JOIN. > Can you update the comment? Done http://gerrit.cloudera.org:8080/#/c/2792/1/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java: Line 2760: "where not exists (select 1 from with_1) "); > Can you also add a couple of planner tests? (see subquery-rewrite.test) Done -- To view, visit http://gerrit.cloudera.org:8080/2792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ae12f116d026190f3a2a7575cda855317d11e8 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
