Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3232: Allow not-exists uncorrelated subqueries ......................................................................
Patch Set 2: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/2792/2/fe/src/main/java/com/cloudera/impala/analysis/StmtRewriter.java File fe/src/main/java/com/cloudera/impala/analysis/StmtRewriter.java: Line 423: for if uncorrelated looks like the sentence is not complete http://gerrit.cloudera.org:8080/#/c/2792/2/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: Line 717: # Uncorrelated NOT EXISTS with a LIMIT 0 clause Did we reject these cases before? Line 724: ==== The query in the JIRA is also a nice test case (WITH clause). You may want to add it as well. http://gerrit.cloudera.org:8080/#/c/2792/2/testdata/workloads/functional-query/queries/QueryTest/subquery.test File testdata/workloads/functional-query/queries/QueryTest/subquery.test: Line 350: that returns an empty set The subquery returns rows, so I don't think the description is accurate. Line 355: order by id I don't think this adds anything to this test case, maybe remove it? -- To view, visit http://gerrit.cloudera.org:8080/2792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52ae12f116d026190f3a2a7575cda855317d11e8 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
