Tim Armstrong has posted comments on this change. Change subject: Fix some ASAN compile warnings and remove redundant flags ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3025/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 63: # -Wno-mismatched-tags: ignore harmless class/struct mismatch for forward declarations. > is this needed for thirdparty code or something? We have this in various places in our code, but gcc doesn't warn about it, or have any way to warn about it. The gcc devs point out that it's completely valid C++ and has no bad consequences: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61339 So even if went through and fixed it in our codebase, it could easily get past pre-commit tests and appear again. I already fixed this in a couple of places a while back, and it reappeared in one of the Kudu patches and produces a lot of noise in the ASAN build. -- To view, visit http://gerrit.cloudera.org:8080/3025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b2772d917449ca747820641c56e65545f610b23 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
