Dan Hecht has posted comments on this change. Change subject: Fix some ASAN compile warnings and remove redundant flags ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3025/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 63: # -Wno-mismatched-tags: ignore harmless class/struct mismatch for forward declarations. > We have this in various places in our code, but gcc doesn't warn about it, okay. how about adding: "Disabling it to be consistent with gcc, which does not have this warning" or something. -- To view, visit http://gerrit.cloudera.org:8080/3025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b2772d917449ca747820641c56e65545f610b23 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
