Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-2809: Improved scalar ByteSwap(). ......................................................................
IMPALA-2809: Improved scalar ByteSwap(). This patch improves our ByteSwap() function by handling more byte sizes in the fast path, as opposed to the loop-based slow path. ByteSwap() is used heavily in when scanning Parquet decimals. Before this patch, VTune showed ByteSwap() among the top three worst cycle offenders when running TPCH-Q6 on my local setup with a large lineitem table. After this patch, ByteSwap() shows no significant contribution to the overall cycles spent. There was a measurable improvement of a few percent for TPCH-Q6. Change-Id: I4f462e6bdb022db46b48889a6a7426120a80d9b4 --- M be/src/util/bit-util.h A be/src/util/bit-util.inline.h M be/src/util/decimal-util.h 3 files changed, 132 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/33/3033/2 -- To view, visit http://gerrit.cloudera.org:8080/3033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f462e6bdb022db46b48889a6a7426120a80d9b4 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
