Tim Armstrong has posted comments on this change. Change subject: IMPALA-2809: Improved scalar ByteSwap(). ......................................................................
Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/3033/2/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 121: for (int i = 0; i < len; ++i) dst[i] = src[len - i - 1]; I've been told we generally avoid these one-line loops, it's probably best to be consistent. Line 127: #endif nit:Extra newline between } and endif -- To view, visit http://gerrit.cloudera.org:8080/3033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f462e6bdb022db46b48889a6a7426120a80d9b4 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
