Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3530: Clean up test_ddl.py. Part 1. ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/3044/1//COMMIT_MSG Commit Message: Line 9: paches nit:typo Line 14: test_creae_table nit:typo Line 19: test_gms_integration nit:typo http://gerrit.cloudera.org:8080/#/c/3044/1/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: Line 179: execute_serially Just curious why we run all these tests serially. May be we can use unique db fixture (instead of ddl_test_db) and remove this? http://gerrit.cloudera.org:8080/#/c/3044/1/tests/metadata/test_ddl_base.py File tests/metadata/test_ddl_base.py: Line 15: logging I think most of the imports here are unused. logging, shlex,time,getpass,call, skips. http://gerrit.cloudera.org:8080/#/c/3044/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: Line 24: logging Not your change, but this has unused imports too. logging, shlex etc. -- To view, visit http://gerrit.cloudera.org:8080/3044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f4c044d39e165c2535961b8d0a765c8dbbd051c Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
