Alex Behm has posted comments on this change. Change subject: IMPALA-3530: Clean up test_ddl.py. Part 1. ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/3044/1//COMMIT_MSG Commit Message: Line 9: This is the first in a series of paches to clean up test_ddl.py > nit:typo Done Line 14: * test_creae_table() > nit:typo Done Line 19: - Move a test into test_gms_integration.py > nit:typo Done http://gerrit.cloudera.org:8080/#/c/3044/1/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: Line 179: @pytest.mark.execute_serially > Just curious why we run all these tests serially. May be we can use unique That's the plan. My goal is to roll out the unique_database fixture in this test, but it is too painful without first cleaning/splitting up this test. So I'm starting with the cleanup, deliberately leaving the unique_database change for later. (Also see JIRA description) http://gerrit.cloudera.org:8080/#/c/3044/1/tests/metadata/test_ddl_base.py File tests/metadata/test_ddl_base.py: Line 15: import logging > I think most of the imports here are unused. logging, shlex,time,getpass,ca Done http://gerrit.cloudera.org:8080/#/c/3044/1/tests/metadata/test_hms_integration.py File tests/metadata/test_hms_integration.py: Line 24: import logging > Not your change, but this has unused imports too. logging, shlex etc. Done -- To view, visit http://gerrit.cloudera.org:8080/3044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f4c044d39e165c2535961b8d0a765c8dbbd051c Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
