Jim Apple has posted comments on this change. Change subject: PREVIEW: Use mmap instead of malloc for buffer pool ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3046/1/be/src/bufferpool/buffer-allocator-test.cc File be/src/bufferpool/buffer-allocator-test.cc: Line 1: // Copyright 2016 Cloudera Inc. Maybe make a benchmark, too? On some systems, mmap is much slower than tcmalloc. -- To view, visit http://gerrit.cloudera.org:8080/3046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
