Tim Armstrong has posted comments on this change. Change subject: PREVIEW: Use mmap instead of malloc for buffer pool ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3046/1/be/src/bufferpool/buffer-allocator-test.cc File be/src/bufferpool/buffer-allocator-test.cc: Line 1: // Copyright 2016 Cloudera Inc. > Maybe make a benchmark, too? On some systems, mmap is much slower than tcma I'd rather wait to benchmark the buffer pool as a whole once the pieces are all put together, since we're going to have free lists for buffers built on top of this. It should be very efficient and not stress mmap() too much once we have that: the buffers will be fairly large and mostly the same size, so we should almost always be able to recycle freed buffers. -- To view, visit http://gerrit.cloudera.org:8080/3046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc748f74adcbbdcfa45f3ec7df98284925acbd6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
