Alex Behm has posted comments on this change. Change subject: IMPALA-2809: Improve scalar ByteSwap(). ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3033/4/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 35: *reinterpret_cast<int16_t*>(dst + 1) = > uint16_t Sorry. Done. Line 36: ByteSwap(*reinterpret_cast<const int16_t*>(src)); > uint16_t Done Line 37: *reinterpret_cast<int8_t*>(dst) = *reinterpret_cast<const int8_t*>(src + 2); > u Done Line 37: *reinterpret_cast<int8_t*>(dst) = *reinterpret_cast<const int8_t*>(src + 2); > u Done -- To view, visit http://gerrit.cloudera.org:8080/3033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f462e6bdb022db46b48889a6a7426120a80d9b4 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
